[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4094238 , @srj wrote: > In D141861#4094084 , @srj wrote: > >> In D141861#4094079 , @jhuber6 >> wrote: >> >>> In D141861#4094063

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4094084 , @srj wrote: > In D141861#4094079 , @jhuber6 wrote: > >> In D141861#4094063 , @srj wrote: >> >>> Yes please! >> >> Let me know if

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4094079 , @jhuber6 wrote: > In D141861#4094063 , @srj wrote: > >> Yes please! > > Let me know if this fixes anything rG9f64fbb882dc >

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4094063 , @srj wrote: > Yes please! Let me know if this fixes anything rG9f64fbb882dc . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4094059 , @jhuber6 wrote: > In D141861#4094058 , @srj wrote: > >> In D141861#4094043 , @jhuber6 >> wrote: >> >>> Would this just require

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4094058 , @srj wrote: > In D141861#4094043 , @jhuber6 wrote: > >> Would this just require checking `LLVM_BUILD_32_BITS`? Should be an easy >> change. > > I think so. (It might

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4094043 , @jhuber6 wrote: > Would this just require checking `LLVM_BUILD_32_BITS`? Should be an easy > change. I think so. (It might be tempting to check `if (CMAKE_SIZEOF_VOID_P EQUAL 8)` but LLVM_BUILD_32_BITS is

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4094036 , @srj wrote: > In D141861#4092237 , @tra wrote: > >> For what it's worth, NVIDIA has started deprecating 32-bit binaries long ago >>

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4092237 , @tra wrote: > For what it's worth, NVIDIA has started deprecating 32-bit binaries long ago > (https://forums.developer.nvidia.com/t/deprecation-plans-for-32-bit-linux-x86-cuda-toolkit-and-cuda-driver/31356) >

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

tra added a comment. For what it's worth, NVIDIA has started deprecating 32-bit binaries long ago (https://forums.developer.nvidia.com/t/deprecation-plans-for-32-bit-linux-x86-cuda-toolkit-and-cuda-driver/31356) and the process had finally come to the end with the release of CUDA-12: CUDA-12

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4092190 , @jhuber6 wrote: > In D141861#4092182 , @srj wrote: > >> In D141861#4092096 , @srj wrote: >> >>> Update: I may have a way to make

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4092182 , @srj wrote: > In D141861#4092096 , @srj wrote: > >> Update: I may have a way to make this work from my side; testing now. > > Alas, that didn't work, stlll broken.

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4092096 , @srj wrote: > Update: I may have a way to make this work from my side; testing now. Alas, that didn't work, stlll broken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4092034 , @srj wrote: > In D141861#4091987 , @jhuber6 wrote: > >> Can you let me know if adding this fixes it. > > Unfortunately, no. (That is: It does not fix it.

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4091987 , @jhuber6 wrote: > Can you let me know if adding this fixes it. Unfortunately, no. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141861/new/

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4091961 , @srj wrote: > In D141861#4091949 , @jhuber6 wrote: > >> In D141861#4091922 , @srj wrote: >> >>> Crosscompiling to x86-32 on

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4091949 , @jhuber6 wrote: > In D141861#4091922 , @srj wrote: > >> Crosscompiling to x86-32 on an x86-64 host doesn't strike me as particularly >> weird at all (especially on

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4091922 , @srj wrote: > Crosscompiling to x86-32 on an x86-64 host doesn't strike me as particularly > weird at all (especially on Windows), but apparently it is quite weird for > LLVM at this point in time as we

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4091903 , @jhuber6 wrote: > In D141861#4091897 , @srj wrote: > >> It's finding a 64-bit CUDAToolkit, which it can't link against because the >> rest of the build is 32-bit. > >

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4091897 , @srj wrote: > It's finding a 64-bit CUDAToolkit, which it can't link against because the > rest of the build is 32-bit. Wondering why it didn't find it before then. But that's definitely a weird

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4091869 , @jhuber6 wrote: > In D141861#4091851 , @srj wrote: > >>> https://github.com/llvm/llvm-project/commit/759dec253695f38a101c74905c819ea47392e515. >>> Does it work if you

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4091851 , @srj wrote: >> https://github.com/llvm/llvm-project/commit/759dec253695f38a101c74905c819ea47392e515. >> Does it work if you revert this? I wouldn't think it wouldn't affect >> anything. That's the only

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. > https://github.com/llvm/llvm-project/commit/759dec253695f38a101c74905c819ea47392e515. > Does it work if you revert this? I wouldn't think it wouldn't affect > anything. That's the only change that happened after the 16 release as far as > I'm aware. Reverting this

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4091408 , @srj wrote: > In D141861#4091403 , @jhuber6 wrote: > >> In D141861#4091383 , @srj wrote: >> >>> It looks like this change

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4091403 , @jhuber6 wrote: > In D141861#4091383 , @srj wrote: > >> It looks like this change (but not the rG4ce454c654bd >>

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4091383 , @srj wrote: > It looks like this change (but not the rG4ce454c654bd > ) is in > the 17 branch, as the latter is now failing in the same

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. In D141861#4060100 , @jhuber6 wrote: > In D141861#4060028 , @srj wrote: > >> This change appears to have broken the build when crosscompiling to x86-32 >> on a Linux x86-64 system; on the

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4060028 , @srj wrote: > This change appears to have broken the build when crosscompiling to x86-32 on > a Linux x86-64 system; on the Halide buildbots, we now fail at link time with > > FAILED: bin/nvptx-arch > :

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 added a comment. In D141861#4060028 , @srj wrote: > This change appears to have broken the build when crosscompiling to x86-32 on > a Linux x86-64 system; on the Halide buildbots, we now fail at link time with > > FAILED: bin/nvptx-arch > :

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

srj added a comment. This change appears to have broken the build when crosscompiling to x86-32 on a Linux x86-64 system; on the Halide buildbots, we now fail at link time with FAILED: bin/nvptx-arch : && /usr/bin/g++-7 -m32 -Wno-psabi -fPIC -fno-semantic-interposition

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9954516ffb10: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build (authored by jhuber6). Changed prior to commit:

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. Yeah, otherwise I suppose there will be some errors when compiling OpenMP program when there is no CUDA installed. Comment at:

[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, yaxunl, JonChesterfield. Herald added subscribers: mattd, gchakrabarti, asavonic. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, jholewinski.