This revision was automatically updated to reflect the committed changes.
Closed by commit rG893d53d11c01: [clang-tidy] Implement
modernize-use-constraints (authored by ccotter, committed by PiotrZSL).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
PiotrZSL accepted this revision.
PiotrZSL added inline comments.
Comment at: clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp:42
+void UseConstraintsCheck::registerMatchers(MatchFinder *Finder) {
+ Finder->addMatcher(
+ functionTemplateDecl(
ccotter marked an inline comment as done.
ccotter added a comment.
> 3. What about boost enable_if ? Support it, or restrict check to std only.
> 4. What about enable_if used as an function argument ? Support it, or add
> some info to documentation that such construction is not supported.
I
ccotter updated this revision to Diff 545450.
ccotter marked 5 inline comments as done.
ccotter added a comment.
- Improve docs, check for null/empty
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141892/new/
https://reviews.llvm.org/D141892
PiotrZSL accepted this revision.
PiotrZSL added a comment.
This revision is now accepted and ready to land.
Overall this check is complicated, simply because it's doing complicated stuff.
1. Add description to all functions (what is their purpose, what is expected
outcome, maybe put some
ccotter updated this revision to Diff 545379.
ccotter added a comment.
- Fix docs
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141892/new/
https://reviews.llvm.org/D141892
Files:
clang-tools-extra/clang-tidy/modernize/CMakeLists.txt
PiotrZSL added inline comments.
Comment at:
clang-tools-extra/docs/clang-tidy/checks/modernize/use-constraints.rst:4
+modernize-use-constraints
+==
+
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
