[PATCH] D141929: Add support for clang-cl's option -fexcess-precision.

2023-01-20 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added a comment. In D141929#4069763 , @thakis wrote: > This breaks tests on macOS: http://45.33.8.238/macm1/53215/step_7.txt > > Please take a look and revert for now if it takes a while to fix. @thakis I reverted it. The fast value of the optio

[PATCH] D141929: Add support for clang-cl's option -fexcess-precision.

2023-01-20 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This breaks tests on macOS: http://45.33.8.238/macm1/53215/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141929/new/ https://reviews.llvm.org/D141

[PATCH] D141929: Add support for clang-cl's option -fexcess-precision.

2023-01-20 Thread Zahira Ammarguellat via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47074683c906: Add support for clang-cl's option `-fexcess-precision`. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D141929: Add support for clang-cl's option /fexcess-precision.

2023-01-18 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam updated this revision to Diff 490183. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141929/new/ https://reviews.llvm.org/D141929 Files: clang/include/clang/Driver/Options.td clang/test/Driver/fexcess-precision.c Index: clang/test/

[PATCH] D141929: Add support for clang-cl's option /fexcess-precision.

2023-01-18 Thread Michael D Toguchi via Phabricator via cfe-commits
mdtoguchi added inline comments. Comment at: clang/include/clang/Driver/Options.td:6654 +def _SLASH_fexcess_precision_EQ : CLJoined<"fexcess-precision=">, + Alias; + To expose to clang-cl, can we just make the original option a `CoreOption` instead of adding an

[PATCH] D141929: Add support for clang-cl's option /fexcess-precision.

2023-01-17 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam updated this revision to Diff 489833. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141929/new/ https://reviews.llvm.org/D141929 Files: clang/include/clang/Driver/Options.td clang/test/Driver/cl-options.c Index: clang/test/Driver/cl-options.c ==