[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

ChuanqiXu updated this revision to Diff 494511. ChuanqiXu added a comment. This is only part of the original revision, which contains platform independent assertion only. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141992/new/ https://reviews.llvm.org/D141992 Files: clang/include/

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

erichkeane added a comment. In D141992#4063978 , @ChuanqiXu wrote: >> Ah, Windows build failures are obviously relevant :) One gotcha here is >> going to be to chase down all the sizes of the records on different >> platforms. > > The failure shouldn't

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

ChuanqiXu added a comment. It passes on the previous windows CI. It looks like the assertion for `sizeof(...)` is indeed not a good idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141992/new/ https://reviews.llvm.org/D141992 _

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

thakis added a comment. Thanks for the fast revert! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141992/new/ https://reviews.llvm.org/D141992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

thakis added a comment. Also fails on 64-bit windows fwiw: http://45.33.8.238/win/73344/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141992/new/ https://reviews.llvm.org/D141992 ___ cfe-commi

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2313 void ASTDeclWriter::VisitOMPDeclareMapperDecl(OMPDeclareMapperDecl *D) { + static_assert(sizeof(OMPDeclareMapperDecl) == 120, +"You need to update the serializer after yo

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

thakis added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2313 void ASTDeclWriter::VisitOMPDeclareMapperDecl(OMPDeclareMapperDecl *D) { + static_assert(sizeof(OMPDeclareMapperDecl) == 120, +"You need to update the serializer after you c

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc79635cce845: [NFC] [Serialization] Add static assert for the size of the decls to (authored by ChuanqiXu). Herald added a project: clang. Herald add