[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

2023-01-20 Thread Sven van Haastregt via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG149521091499: [OpenCL] Always add nounwind attribute for OpenCL (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

2023-01-20 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh added a comment. In D142033#4062671 , @bader wrote: > Should we generalize and rename `clang/test/CodeGenOpenCL/convergent.cl` to > validate function attributes other than `convergent`? It's not obvious that > presence of `nounwind` attribute is

[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

2023-01-18 Thread Alexey Bader via Phabricator via cfe-commits
bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Should we generalize and rename `clang/test/CodeGenOpenCL/convergent.cl` to validate function attributes other than `convergent`? It's not obvious that presence of `nounwind` attribute is valida

[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

2023-01-18 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142033/new/ https://reviews.llvm.org/D142033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

2023-01-18 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh created this revision. svenvh added reviewers: Anastasia, yaxunl, bader. Herald added subscribers: kosarev, Naghasan, ldrumm, kerbowa, jvesely. Herald added a project: All. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Neith