[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

eopXD created this revision. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal

[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

eopXD updated this revision to Diff 490416. eopXD added a comment. Herald added a subscriber: arphaman. Update test cases under test/CodeGen/RISCV/rvv-intrinsics-handcrafted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142085/new/ https://reviews.

[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

eopXD updated this revision to Diff 490417. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142085/new/ https://reviews.llvm.org/D142085 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Support/RISCVVInt

[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

kito-cheng added a comment. Could you split testcase update to a separated patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142085/new/ https://reviews.llvm.org/D142085 ___ cfe-commits mailing list c

[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vaadd.c:5-14 // RUN: FileCheck --check-prefix=CHECK-RV64 %s #include -// CHECK-RV64-LABEL: @test_vaadd_vv_i8mf8( +// CHECK-RV64-LABEL: @test__

[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1535 enum RVV_CSR { RVV_VSTART = 0, RVV_VXSAT, Not related to this patch, but this enum should probably be using double underscores for its names. Repository: rG

[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

jrtc27 added a comment. (For some reason Phab won't let me comment inline from the Changeset View page, just does nothing when I click reply or click a line...) Or just leave the test names alone? The __riscv_ is for namespacing the intrinsics, you don't need to namespace the tests when they're

[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

eopXD added a comment. > Not related to this patch, but this enum should probably be using double > underscores for its names. Thanks for mentioning this, probably should start a PR under rvv-intrinsic-doc before having a patch here. @craig.topper @kito-cheng I don't have a preference here, is

[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

kito-cheng added a comment. > I don't have a preference here, is any of __riscv_RVV_CSR/ > __riscv_rvv_csr_type / __riscv_rvv_csr_t suitable? Either is fine to me at this stage, I expect they will be drop soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

kito-cheng added a comment. Agree with @jrtc27 about the test function name, we could keep the function name in the test file, that's also reduce lots of diff which is not really necessary. e.g. `vint8mf8_t test_vaadd_vv_i8mf8(vint8mf8_t op1, vint8mf8_t op2, size_t vl)` keep same name rather t