[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

2023-02-01 Thread Jan Sjödin via Phabricator via cfe-commits
jsjodin added a comment. In D142244#4096777 , @clementval wrote: > In D142244#4096648 , @jsjodin wrote: > >> In D142244#4096579 , @clementval >> wrote: >> >>> In

[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

2023-02-01 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. In D142244#4096648 , @jsjodin wrote: > In D142244#4096579 , @clementval > wrote: > >> In D142244#4096546 , @jsjodin >> wrote: >> >>> In

[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

2023-02-01 Thread Jan Sjödin via Phabricator via cfe-commits
jsjodin added a comment. In D142244#4096579 , @clementval wrote: > In D142244#4096546 , @jsjodin wrote: > >> In D142244#4096538 , @clementval >> wrote: >> >>> In

[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

2023-02-01 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. In D142244#4096546 , @jsjodin wrote: > In D142244#4096538 , @clementval > wrote: > >> In D142244#4096512 , @jsjodin >> wrote: >> >>> No, it

[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

2023-02-01 Thread Jan Sjödin via Phabricator via cfe-commits
jsjodin added a comment. In D142244#4096538 , @clementval wrote: > In D142244#4096512 , @jsjodin wrote: > >> No, it should work for any configuration as far as I know. How are you >> running the test? > > Just

[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

2023-02-01 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. In D142244#4096512 , @jsjodin wrote: > No, it should work for any configuration as far as I know. How are you > running the test? Just with `check-flang` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

2023-02-01 Thread Jan Sjödin via Phabricator via cfe-commits
jsjodin added a comment. In D142244#4096492 , @clementval wrote: > The new test embed.f90 and embed-error.f90 are failing on my side. Do they > assume a specific configuration? No, it should work for any configuration as far as I know. How are you

[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

2023-02-01 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. The new test embed.f90 and embed-error.f90 are failing on my side. Do they assume a specific configuration? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142244/new/ https://reviews.llvm.org/D142244

[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

2023-01-31 Thread Jan Sjödin via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40d8c0666f19: [flang][driver] Add support for -embed-offload-object flag in flang (authored by jsjodin). Herald added projects: clang, Flang. Herald