This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGab49747f9d67: [NFC][Clang] Move DebugOptions to
llvm/Frontend for reuse in Flang (authored by kiranchandramohan, committed by
SBallantyne).
Reposit
awarzynski accepted this revision.
awarzynski added a comment.
LGTM, thanks! As @kiranchandramohan points out, this is in line with the
overall direction that we agreed on a while back.
This change will very likely affect various downstream consumers - it would be
helpful to advertise this with
SBallantyne updated this revision to Diff 508617.
SBallantyne added a comment.
Remove references to non existing import
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142347/new/
https://reviews.llvm.org/D142347
Files:
clang/include/clang/Basic/C
kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.
LGTM. This refactoring helps share code between Clang and Flang. Please wait a
couple of days before submitting.
Additional notes in support of approval:
-> The llvm comm
SBallantyne updated this revision to Diff 508532.
SBallantyne added a comment.
Clang format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142347/new/
https://reviews.llvm.org/D142347
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/in
SBallantyne updated this revision to Diff 508150.
SBallantyne added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142347/new/
https://reviews.llvm.org/D142347
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/include/
SBallantyne commandeered this revision.
SBallantyne added a reviewer: kiranchandramohan.
SBallantyne added a comment.
Setting this revision as base for adding debug flag to avoid adding additional
dependencies on clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://
kiranchandramohan created this revision.
Herald added a subscriber: sunshaoce.
Herald added a project: All.
kiranchandramohan requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, MaskRay.
Herald added projects: clang, LLVM.
Repository:
rG LLVM Github Monorepo