[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

This revision was automatically updated to reflect the committed changes. Closed by commit rG97ba3c2bec48: [Clang][AMDGPU] Set LTO CG opt level based on Clang option (authored by scott.linder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142499/new

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142499/new/ https://reviews.llvm.org/D142499 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Fine with me, but you may need an AMDGPU reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142499/new/ https://reviews.llvm.org/D142499

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

scott.linder added a comment. Are there any thoughts on whether this is too ugly to live? It will be awkward to teach users the current default behavior without this change, but if we can accept it as a historical quirk that may be OK. The primary driver for wanting the 1:1 mapping is an odd in

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

scott.linder updated this revision to Diff 494435. scott.linder added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142499/new/ https://reviews.llvm.org/D142499 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driv

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

scott.linder updated this revision to Diff 492205. scott.linder added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142499/new/ https://reviews.llvm.org/D142499 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driv

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

scott.linder added a comment. In D142499#4078177 , @arsenm wrote: > Making this target specific doesn’t make sense I don't know how else to resolve others wanting the default to be the `CGOptLevel = clamp(ltoOptLevel, 2, 3)` behavior and AMDGPU wanting

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

arsenm added a comment. Making this target specific doesn’t make sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142499/new/ https://reviews.llvm.org/D142499 ___ cfe-commits mailing list cfe-commits@

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

scott.linder added reviewers: arsenm, yaxunl, scchan, pcc, MaskRay, mehdi_amini, respindola, ruiu, aheejin, sbc100. scott.linder added a comment. (Just adding everyone from the parent review, feel free to remove yourself as reviewer if you aren't interested!) It isn't ideal, but as only AMDGCN

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

scott.linder created this revision. Herald added subscribers: kosarev, inglorion, tpr, dstuttard, yaxunl, kzhuravl. Herald added a project: All. scott.linder requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, wdng. Herald added a project: clang. For AMDGCN default t