[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

2023-01-26 Thread Zahira Ammarguellat via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4b06d8ff826: __arithmetic_fence enforces ordering on expression evaluation when fast-math (authored by zahiraam). Repository: rG LLVM Github

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

2023-01-26 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added a comment. In D142583#4083251 , @bader wrote: > LGTM. Thanks! Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142583/new/ https://reviews.llvm.org/D142583 ___ cfe-commits

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

2023-01-26 Thread Alexey Bader via Phabricator via cfe-commits
bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142583/new/ https://reviews.llvm.org/D142583 ___ cfe-commits mailing list

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

2023-01-26 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added inline comments. Comment at: clang/test/CodeGen/arithmetic-fence-builtin.c:73 int subit(float a, float b, float *fp) { - // CHECKFAST: define {{.*}}@subit(float noundef %a, float noundef %b{{.*}} + // CHECKPRECISE: define {{.*}}@subit(float noundef %a, float

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

2023-01-26 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam updated this revision to Diff 492483. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142583/new/ https://reviews.llvm.org/D142583 Files: clang/lib/Basic/Targets/SPIR.h clang/test/CodeGen/arithmetic-fence-builtin.c clang/test/Sema/arithmetic-fence-builtin.c Index:

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

2023-01-26 Thread Alexey Bader via Phabricator via cfe-commits
bader added inline comments. Comment at: clang/test/CodeGen/arithmetic-fence-builtin.c:73 int subit(float a, float b, float *fp) { - // CHECKFAST: define {{.*}}@subit(float noundef %a, float noundef %b{{.*}} + // CHECKPRECISE: define {{.*}}@subit(float noundef %a, float

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

2023-01-26 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam updated this revision to Diff 492410. zahiraam marked 3 inline comments as done. zahiraam edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142583/new/ https://reviews.llvm.org/D142583 Files: clang/lib/Basic/Targets/SPIR.h