[PATCH] D14259: The maximum alignment of std::aligned_storage applies to all Windows compilers

2016-10-07 Thread Marshall Clow via cfe-commits
mclow.lists closed this revision. mclow.lists added a comment. This duplicates @D25053, and I've landed this change as revision 283621. https://reviews.llvm.org/D14259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14259: The maximum alignment of std::aligned_storage applies to all Windows compilers

2016-09-26 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. I guess this is OK. I'd rather not have naked `_WIN32` references outside of <__config>, but this is not the first one. https://reviews.llvm.org/D14259 ___ cfe-commits mailing list

Re: [PATCH] D14259: The maximum alignment of std::aligned_storage applies to all Windows compilers

2016-09-26 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D14259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14259: The maximum alignment of std::aligned_storage applies to all Windows compilers

2015-11-02 Thread Saleem Abdulrasool via cfe-commits
compnerd added a subscriber: compnerd. compnerd accepted this revision. compnerd added a reviewer: compnerd. compnerd added a comment. This revision is now accepted and ready to land. Yeah, this is a COFF limitation. Its unfortunate we don't have a better way to detect COFF targets.

[PATCH] D14259: The maximum alignment of std::aligned_storage applies to all Windows compilers

2015-11-02 Thread Reid Kleckner via cfe-commits
rnk created this revision. rnk added reviewers: danalbert, mclow.lists. rnk added a subscriber: cfe-commits. According to Clang's sources, the maximum supported storage alignment is a property of the COFF object file format. Fixes building libc++ with Clang on Windows.