[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

ymandel added a comment. In D142710#4097032 , @xazax.hun wrote: > In D142710#4096325 , @ymandel wrote: > >> In D142710#4094934 , @xazax.hun >> wrote: >> >>> This change

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

xazax.hun added a comment. In D142710#4096325 , @ymandel wrote: > In D142710#4094934 , @xazax.hun > wrote: > >> This change looks good to me. I wonder, however, whether the behavior should >> be parameterized

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4fb829b7180: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`. (authored by ymandel). Repository: rG LLVM Github

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

ymandel added a comment. In D142710#4094934 , @xazax.hun wrote: > This change looks good to me. I wonder, however, whether the behavior should > be parameterized in the future. E.g., whether the user of the analysis should > be able to make a decision

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. This change looks good to me. I wonder, however, whether the behavior should be parameterized in the future. E.g., whether the user of the analysis should be able to make a decision

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

ymandel marked 2 inline comments as done. ymandel added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142710/new/ https://reviews.llvm.org/D142710 ___ cfe-commits mailing list

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:524 -void transferSwap(const StorageLocation , - const StorageLocation , -

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:524 -void transferSwap(const StorageLocation , - const StorageLocation , - LatticeTransferState ) { - auto *OptionalVal1 =

[PATCH] D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`.

ymandel created this revision. ymandel added reviewers: sgatev, gribozavr2, xazax.hun. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Currently, the interpretation of