[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet added a comment. In D142890#4149181 , @vitalybuka wrote: > One of your patches likely introduced UB > https://lab.llvm.org/buildbot/#/builders/85/builds/14558 > Can you please take a look? Thanks a lot Vitaly and sorry for not noticing this

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

vitalybuka added subscribers: kstoimenov, vitalybuka. vitalybuka added a comment. One of your patches likely introduced UB https://lab.llvm.org/buildbot/#/builders/85/builds/14558 Can you please take a look? FYI, @kstoimenov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG7177a237b68f: [clangd] Add config option for fast diagnostics mode (authored by kadircet). Changed prior to commit:

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/PreambleTests.cpp:235 MockFS FS; - auto TU = TestTU::withCode(Modified); + auto = PreambleTU; + TU.Code =

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet updated this revision to Diff 495889. kadircet added a comment. - Insert missing include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142890/new/ https://reviews.llvm.org/D142890 Files: clang-tools-extra/clangd/Config.h

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet updated this revision to Diff 495879. kadircet marked 10 inline comments as done. kadircet added a comment. - Use raw string literals - Make tests more expressive by mentioning diagnostic names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/PreambleTests.cpp:624 + + llvm::StringLiteral BaselinePreamble = "#define FOO\n"; + { sammccall wrote: > nit: "preamble" vs "code" is a confusing distinction when we're using both

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

sammccall added a comment. The code looks good, but I have a very hard time following the tests. Comment at: clang-tools-extra/clangd/unittests/PreambleTests.cpp:225 auto TU = TestTU::withCode(Modified); + TU.AdditionalFiles = std::move(AdditionalFiles); auto CI =

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet updated this revision to Diff 495407. kadircet added a comment. - Update tests after discussions in D143096 to be line-oriented, rather than being directive-oriented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet marked 5 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/ConfigCompileTests.cpp:555 + EXPECT_TRUE(compileAndApply()); + // Defaults to Strict. + EXPECT_EQ(Conf.Diagnostics.Mode, Config::DiagnosticsMode::Fast);

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet updated this revision to Diff 495159. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142890/new/ https://reviews.llvm.org/D142890 Files:

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:243 +/// - Strict +std::optional> Mode; + kadircet wrote: > sammccall wrote: > > I think "Diagnostics.Mode" is too vague a name. > > > > I expect this to be a rollout

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:243 +/// - Strict +std::optional> Mode; + sammccall wrote: > I think "Diagnostics.Mode" is too vague a name. > > I expect this to be a rollout flag that we remove in

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet updated this revision to Diff 494003. kadircet added a comment. Wire up the feature and add some test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142890/new/ https://reviews.llvm.org/D142890 Files:

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:243 +/// - Strict +std::optional> Mode; + I think "Diagnostics.Mode" is too vague a name. I expect this to be a rollout flag that we remove in the medium term (either

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.