[PATCH] D142985: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

2023-02-01 Thread Joseph Huber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c4591d7f3ac: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state (authored by jhuber6). Repository: rG LLVM Github Monore

[PATCH] D142985: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

2023-02-01 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142985/new/ https://reviews.llvm.org/D142985 _

[PATCH] D142985: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

2023-02-01 Thread Mikael Holmén via Phabricator via cfe-commits
uabelho resigned from this revision. uabelho added a comment. In D142985#4096297 , @jhuber6 wrote: > In D142985#4095701 , @uabelho wrote: > >> I wrote >> https://github.com/llvm/llvm-project/issues/60437 > > Grea

[PATCH] D142985: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

2023-02-01 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D142985#4095701 , @uabelho wrote: > I wrote > https://github.com/llvm/llvm-project/issues/60437 Great, I'll land it once the patch is accepted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D142985: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

2023-01-31 Thread Mikael Holmén via Phabricator via cfe-commits
uabelho added a comment. In D142985#4093783 , @jhuber6 wrote: > If this fixes the issues on your side, please open a bug so it can be > backported. I wrote https://github.com/llvm/llvm-project/issues/60437 Repository: rG LLVM Github Monorepo CHANG

[PATCH] D142985: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

2023-01-31 Thread Mikael Holmén via Phabricator via cfe-commits
uabelho added a comment. @jhuber6 I really have no idea about the fix, but I've run the linker-wrapper.c testcase with asan built binaries with this fix 500 times now without seeing any failures. Without the fix it fails in like 1 out of 10 runs so it surely looks like the fix does something g

[PATCH] D142985: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

2023-01-31 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. If this fixes the issues on your side, please open a bug so it can be backported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142985/new/ https://reviews.llvm.org/D142985 ___

[PATCH] D142985: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

2023-01-31 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 created this revision. jhuber6 added a reviewer: uabelho. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There were intemittent errors in the linker wrapper when using the sanitizers in parallel