[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

2023-02-04 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght updated this revision to Diff 494821. Backl1ght added a comment. add more unittest CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143091/new/ https://reviews.llvm.org/D143091 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Form

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

2023-02-04 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3891 + * ``PCIS_OnlyNextLine`` (in configuration: ``OnlyNextLine``) +Put all constructor initializers on the next line if they fit. Backl1ght wrote: > @HazardyKnusperkeks M

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

2023-02-03 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3891 + * ``PCIS_OnlyNextLine`` (in configuration: ``OnlyNextLine``) +Put all constructor initializers on the next line if they fit. @HazardyKnusperkeks Maybe I misunder

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

2023-02-03 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. In D143091#4099585 , @Backl1ght wrote: > In D143091#4097534 , > @HazardyKnusperkeks wrote: > >> An entry in the changelog would be nice. > > It is already added I think. I don

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

2023-02-02 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght marked an inline comment as done. Backl1ght added a comment. In D143091#4097534 , @HazardyKnusperkeks wrote: > An entry in the changelog would be nice. It is already added I think. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143091

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

2023-02-02 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght updated this revision to Diff 494281. Backl1ght added a comment. adapt suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143091/new/ https://reviews.llvm.org/D143091 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Forma

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

2023-02-01 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. An entry in the changelog would be nice. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1406-1408 + CurrentState.BreakBeforeParameter = !( + Style.PackConstructorInitializers == FormatStyle::PCIS_NextLine || + St