[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03f5326d8166: [Tooling/Inclusion] Introduce a human-edit file for C++ std symbols (authored by hokein). Repository: rG LLVM Github Monorepo

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143160/new/ https://reviews.llvm.org/D143160

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

hokein added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdAlternativeHeaderMap.inc:3 +// +// This is a hand-curated list for C++ symbols (e.g. provided by multiple +// headers), to address the short comings of cppreference or automated

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

hokein updated this revision to Diff 495100. hokein added a comment. Rename the file name for more general purposes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143160/new/ https://reviews.llvm.org/D143160 Files:

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdAlternativeHeaderMap.inc:3 +// +// This is a hand-curated list for C++ symbols (e.g. provided by multiple +// headers), to address the short comings of cppreference or automated

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

hokein added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdAlternativeHeaderMap.inc:3 +// +// This is a hand-curated list for C++ symbols (e.g. provided by multiple +// headers), to address the short comings of cppreference or automated

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdAlternativeHeaderMap.inc:3 +// +// This is a hand-curated list for C++ symbols (e.g. provided by multiple +// headers), to address the short comings of cppreference or automated

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

hokein added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/CXXSymbolMap.inc:1 +//===-- CXXSymbolMap.inc *- C++ -*-===// +// kadircet wrote: > also maybe rename this to, `AlternativeHeaderMap.inc` ?

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

hokein updated this revision to Diff 495032. hokein marked an inline comment as done. hokein edited the summary of this revision. hokein added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143160/new/

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/CXXSymbolMap.inc:1 +//===-- CXXSymbolMap.inc *- C++ -*-===// +// also maybe rename this to, `AlternativeHeaderMap.inc` ?

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/CXXSymbolMap.inc:12 +SYMBOL(consume_header, std::, ) // declared +SYMBOL(consume_header, std::, ) // defined +SYMBOL(generate_header, std::, ) i feel like cppreference is wrong

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

hokein updated this revision to Diff 494573. hokein added a comment. refine the patch: include multiple-header symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143160/new/ https://reviews.llvm.org/D143160 Files: