[PATCH] D143301: Emit warning for unsupported gfortran flags

2023-02-14 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. In D143301#4126884 , @elmcdonough wrote: > Thanks for the feedback everyone. This is my current understanding on what I > should do: I am to rename gfortran_unsupported_Group to flang_ignored_w_Group > and move the non W

[PATCH] D143301: Emit warning for unsupported gfortran flags

2023-02-14 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. In D143301#4126855 , @jdoerfert wrote: > In D143301#4126712 , @awarzynski > wrote: > >>> I think the -W stuff can go in, it has tests and is reasonable. >> >> I'd like for us to rely

[PATCH] D143301: Emit warning for unsupported gfortran flags

2023-02-14 Thread Ethan Luis McDonough via Phabricator via cfe-commits
elmcdonough added a comment. Thanks for the feedback everyone. This is my current understanding on what I should do: I am to rename gfortran_unsupported_Group to flang_ignored_w_Group and move the non W group gfortran options into another patch. I have these changes locally and am currently

[PATCH] D143301: Emit warning for unsupported gfortran flags

2023-02-14 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D143301#4126712 , @awarzynski wrote: >> I think the -W stuff can go in, it has tests and is reasonable. > > I'd like for us to rely on a flag from Options.td for this instead. Something > similar to clang_ignored_f_Group

[PATCH] D143301: Emit warning for unsupported gfortran flags

2023-02-14 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. In D143301#4126682 , @jdoerfert wrote: > Split this into two patches/reviews. +1 > I think the -W stuff can go in, it has tests and is reasonable. I'd like for us to rely on a flag from Options.td for this instead.

[PATCH] D143301: Emit warning for unsupported gfortran flags

2023-02-14 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Split this into two patches/reviews. I think the -W stuff can go in, it has tests and is reasonable. The other stuff needs tests too. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:607 if (args.hasArg(clang::driver::options::OPT_W_Joined))

[PATCH] D143301: Emit warning for unsupported gfortran flags

2023-02-11 Thread Ethan Luis McDonough via Phabricator via cfe-commits
elmcdonough updated this revision to Diff 496730. elmcdonough retitled this revision from "Emit warning for `-Wextra` instead of error" to "Emit warning for unsupported gfortran flags". elmcdonough added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. This