[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c8fe9658236: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from… (authored by RKSimon). Changed prior to commit: https://

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143318/new/ https://reviews.llvm.org/D143318

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

nhaehnle added a comment. This (moving to ProfileData) seems like a simple and pragmatic solution for a (perhaps not gigantic but) real problem. It feels fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143318/new/ https://reviews.llvm.or

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

RKSimon updated this revision to Diff 494925. RKSimon added a comment. fix the git diff lost renames Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143318/new/ https://reviews.llvm.org/D143318 Files: clang/docs/tools/clang-formatted-files.txt l

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

RKSimon updated this revision to Diff 494917. RKSimon added a comment. Add bazel build fix for llvm-cxxmap Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143318/new/ https://reviews.llvm.org/D143318 Files: clang/docs/tools/clang-formatted-files.t

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

chapuni added a comment. @RKSimon Could you cherry-pick it? https://github.com/chapuni/llvm-project/commit/2c09237d8759bb6b1e99940e78901bde5b2bb98f As a position to reduce overhead in tblgen, I don't agree to move this to LLVMDemangle. LLVMSupport depends on LLVMDemangle. llvm-tblgen depends on

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

RKSimon added a comment. In D143318#4104410 , @phosek wrote: > Another alternative would be to move these classes to the Demangle library. I'm happy to move this to LLVMDemangle instead if everyone agrees. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

RKSimon added a comment. In D143318#4104408 , @MaskRay wrote: > `ItaniumManglingCanonicalizer.cpp` doesn't have many includes. I think it is > fine to remain in llvm/lib/Support ... The frontend cost might not be high - but ItaniumManglingCanonicalizer.

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

phosek added a comment. Another alternative would be to move these classes to the Demangle library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143318/new/ https://reviews.llvm.org/D143318 ___ cfe-comm

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

MaskRay added a comment. `ItaniumManglingCanonicalizer.cpp` doesn't have many includes. I think it is fine to remain in llvm/lib/Support ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143318/new/ https://reviews.llvm.org/D143318 __

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

RKSimon created this revision. RKSimon added reviewers: rsmith, chapuni, MaskRay, kristina, erik.pilkington. Herald added subscribers: wenlei, hiraditya. Herald added a project: All. RKSimon requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commit