[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 499433. DmitryPolukhin added a comment. Move call addTargetAndModeForProgramName after SystemIncludeExtractor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 F

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

nridge added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:222 + tooling::addExpandedResponseFiles(Cmd, Command.Directory, Tokenizer, *FS); + tooling::addTargetAndModeForProgramName(Cmd, Cmd.front()); auto &OptTable = clang::driver::getDriverOptTa

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:222 + tooling::addExpandedResponseFiles(Cmd, Command.Directory, Tokenizer, *FS); + tooling::addTargetAndModeForProgramName(Cmd, Cmd.front()); auto &OptTable = clang::driver::getDri

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

nridge added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:222 + tooling::addExpandedResponseFiles(Cmd, Command.Directory, Tokenizer, *FS); + tooling::addTargetAndModeForProgramName(Cmd, Cmd.front()); auto &OptTable = clang::driver::getDriverOptTa

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin added a comment. @nridge @kadircet please take another look, all tests now pass. As for the location of inserting driver mode please see my previous comment about MSVC CL check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/n

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 498878. DmitryPolukhin added a comment. Rebase and retest, cannot reproduce test failure locally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 498140. DmitryPolukhin added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.cpp cla

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin added a comment. @nridge I'm sorry, I pushed version without all tests. Now I added test case for response files, it seems that clangd hasn't had it before this patch. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:222 + tooling::addExpandedResponseFi

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 498138. DmitryPolukhin added a comment. Add test for expanded response files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

nridge added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:222 + tooling::addExpandedResponseFiles(Cmd, Command.Directory, Tokenizer, *FS); + tooling::addTargetAndModeForProgramName(Cmd, Cmd.front()); auto &OptTable = clang::driver::getDriverOptTa

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

nridge added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:222 + tooling::addExpandedResponseFiles(Cmd, Command.Directory, Tokenizer, *FS); + tooling::addTargetAndModeForProgramName(Cmd, Cmd.front()); auto &OptTable = clang::driver::getDriverOptTa

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 498038. DmitryPolukhin added a comment. Move standard adaptors to CommandMangler Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/cla

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin added a comment. In D143436#4122594 , @kadircet wrote: > That's actually because we model compile commands pushed via LSP as a "fixed > compilation database" rather than a json compilation database (you can check > the code in `parseFixed

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

kadircet added a comment. > There is a discrepancy between how clangd processes CDB loaded from JSON file > on disk and pushed via LSP. That's actually because we model compile commands pushed via LSP as a "fixed compilation database" rather than a json compilation database (you can check the

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin added a comment. In D143436#4120899 , @nridge wrote: > Note that D138546 is removing the call to > `inferTargetAndDriverMode()` from `GlobalCompilationDatabase.cpp`. It adds > equivalent logic too `Comma

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

nridge added a comment. Note that D138546 is removing the call to `inferTargetAndDriverMode()` from `GlobalCompilationDatabase.cpp`. It adds equivalent logic too `CommandMangler` which is used for CDBs pushed from LSP as well, so it accomplishes objective of t

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 495431. DmitryPolukhin added a comment. Fix clang-format sources Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/ClangdLSPSer

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: sammccall, ilya-biryukov. DmitryPolukhin added projects: clang, clang-tools-extra. Herald added subscribers: s.egerton, kadircet, arphaman, simoncook. Herald added a project: All. DmitryPolukhin requested review of this revision.