This revision was automatically updated to reflect the committed changes.
Closed by commit rG38b1a17c519d: [clang-tidy] allow tests to use --config-file
instead of --config (authored by amurzeau, committed by PiotrZSL).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://re
amurzeau added a comment.
I do not have commit access to the repo, can someone commit this patch for me ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144037/new/
https://reviews.llvm.org/D144037
___
cf
carlosgalvezp accepted this revision.
carlosgalvezp added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the fix!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144037/new/
https://reviews.llvm.org/D144037
amurzeau updated this revision to Diff 497773.
amurzeau retitled this revision from "[clang-tidy] allow tests to use
-config-file instead of -config" to "[clang-tidy] allow tests to use
--config-file instead of --config".
amurzeau added a comment.
Allow use of --config and --config-file (with do
carlosgalvezp requested changes to this revision.
carlosgalvezp added a comment.
This revision now requires changes to proceed.
LGTM except the comments left by other reviewers! Marking it as "Request
Changes" for visibility.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ht
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:111
if not any(
-[arg.startswith('-config=') for arg in self.clang_tidy_extra_args]):
+[arg.startswith('-config=') or arg.startswith('-config-file=') for a
ClockMan added inline comments.
Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:111
if not any(
-[arg.startswith('-config=') for arg in self.clang_tidy_extra_args]):
+[arg.startswith('-config=') or arg.startswith('-config-file=') for arg
in
amurzeau created this revision.
amurzeau added reviewers: njames93, alexfh, kazu, dougpuob.
Herald added a subscriber: xazax.hun.
Herald added a project: All.
amurzeau requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
The previous