[PATCH] D14411: Use __attribute__((internal_linkage)) when available.

ldionne added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. I think this should be closed since the work we did on `internal_linkage` in 2018. @eugenis Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14411/new/

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

EricWF added a comment. Sorry about the long delay in reviewing this. @eugenis Are you still able/willing to proceed with this? Repository: rL LLVM http://reviews.llvm.org/D14411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

eugenis added dependencies: D15433: [libcxx] Remove inline/visibility attributes from exported template methods in valarray., D15432: [libcxx] Move member function definition before it's explicit template instantiation declaration in to satisfy GCC.. eugenis added a comment. Depends on

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

eugenis added a comment. With http://reviews.llvm.org/D15434, there is no difference in libc++ export list with the switch to internal_linkage. Repository: rL LLVM http://reviews.llvm.org/D14411 ___ cfe-commits mailing list

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

eugenis added a dependency: D12502: [libcxx] Better constain tuples constructors -- Fix PR23256 and PR22806. eugenis added a comment. Note, this breaks tuple_cat.pass.cpp test. With -O0, replacing always_inline with internal_linkage results in less optimization being done (namely, no inlining

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

eugenis added a dependency: D15404: Cleanup: move visibility/linkage attributes to the first declaration (part 2).. eugenis added a comment. This change depends on http://reviews.llvm.org/D15404. Repository: rL LLVM http://reviews.llvm.org/D14411

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

EricWF added a comment. Why does this depend on http://reviews.llvm.org/D15404? Repository: rL LLVM http://reviews.llvm.org/D14411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

EricWF added a comment. In http://reviews.llvm.org/D14411#306716, @EricWF wrote: > Why does this depend on http://reviews.llvm.org/D15404? Woops, I meant the tuple patch but I see the other comment now. I'm curious as to how inlininging ends up affecting which overload's SFINAE are

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

eugenis added a comment. In http://reviews.llvm.org/D14411#306722, @EricWF wrote: > In http://reviews.llvm.org/D14411#306716, @EricWF wrote: > > > Why does this depend on http://reviews.llvm.org/D15404? > > > Woops, I meant the tuple patch but I see the other comment now. I'm curious > as to

[PATCH] D14411: Use __attribute__((internal_linkage)) when available.

eugenis created this revision. eugenis added reviewers: EricWF, mclow.lists. eugenis added a subscriber: cfe-commits. eugenis set the repository for this revision to rL LLVM. Use __attribute__((internal_linkage)) instead of always_inline and visibility("hidden") when it is available.