probinson created this revision.
probinson added a reviewer: ChuanqiXu.
Herald added a project: All.
probinson requested review of this revision.
https://reviews.llvm.org/D144188
Files:
clang/test/CXX/module/basic/basic.def.odr/p4.cppm
Index: clang/test/CXX/module/basic/basic.def.odr/p4.cppm
probinson added a comment.
I looked at this test only because it caused a merge conflict downstream. While
it does work, it will not catch some kinds of mistakes; by being less specific
in the "not" checks, it will catch more potential problems.
Comment at: clang/test/CXX/mod
ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144188/new/
https://reviews.llvm.org/D144188
___
cfe-commits mailing lis
This revision was automatically updated to reflect the committed changes.
Closed by commit rG17a90f1196c1: Tighten up a modules test (authored by
probinson).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144188/new/
ht
