This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc21378f90a44: [clangd/index/remote]NFC: Adapt code to newer
grpc/protobuf versions (authored by MatzeB).
Repository:
rG LLVM Github Monorepo
MatzeB updated this revision to Diff 499909.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144599/new/
https://reviews.llvm.org/D144599
Files:
clang-tools-extra/clangd/index/remote/monitor/Monitor.cpp
Index:
MatzeB added a comment.
> Asking as it'd be great to know that we've adoption here, outside of
> ourselves.
I'm not involved in any of this myself. But @kuganv is :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144599/new/
kuganv added a comment.
> if you don't mind me asking, are you deliberately building remote-index
> components? i.e. do you have an internal remote-index server/deployment ?
> Asking as it'd be great to know that we've adoption here, outside of
> ourselves.
>
> OTOH, if you're not actually
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, indeed the protobuf version used by grpc-1.36.3 has these available,
MatzeB added a comment.
I need this change to fix compilation in our environment which uses
`grpc-1.42.0`...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144599/new/
https://reviews.llvm.org/D144599
MatzeB created this revision.
MatzeB added reviewers: kbobyrev, kuganv.
Herald added subscribers: modimo, wenlei, kadircet, arphaman, mcrosier.
Herald added a project: All.
MatzeB requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a
