[PATCH] D144713: [Tooling/Includsion] Add the missing NULL symbol to the table.

2023-02-24 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGc86f05dd48d2: [Tooling/Inclusion] Add the missing NULL symbol to the table. (authored by hokein). Repositor

[PATCH] D144713: [Tooling/Includsion] Add the missing NULL symbol to the table.

2023-02-24 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144713/new/ https://reviews.llvm.org/D144713

[PATCH] D144713: [Tooling/Includsion] Add the missing NULL symbol to the table.

2023-02-24 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 500126. hokein added a comment. oops, fix the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144713/new/ https://reviews.llvm.org/D144713 Files: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.in

[PATCH] D144713: [Tooling/Includsion] Add the missing NULL symbol to the table.

2023-02-24 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc:242 +// Macros +SYMBOL(NULL, , ) +SYMBOL(NULL, , ) we use `None` for global namespace rather than leaving empty. let's keep it that way? Repository: rG LL

[PATCH] D144713: [Tooling/Includsion] Add the missing NULL symbol to the table.

2023-02-24 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D144713 Files: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSym