This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rGc86f05dd48d2: [Tooling/Inclusion] Add the missing NULL
symbol to the table. (authored by hokein).
Repositor
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144713/new/
https://reviews.llvm.org/D144713
hokein updated this revision to Diff 500126.
hokein added a comment.
oops, fix the patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144713/new/
https://reviews.llvm.org/D144713
Files:
clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.in
kadircet added inline comments.
Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc:242
+// Macros
+SYMBOL(NULL, , )
+SYMBOL(NULL, , )
we use `None` for global namespace rather than leaving empty. let's keep it
that way?
Repository:
rG LL
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added a project: All.
hokein requested review of this revision.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D144713
Files:
clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSym