[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4cb6c208231: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C (authored by amurzeau, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau added a comment. In D144912#4204088 , @carlosgalvezp wrote: > Looks great, approved! Thanks for fixing :) Thanks for the review :) I don't have push access, so please can you (or anyone else) land it for me ? (as `Alexis Murzeau ` (phabricator

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. > Without this patch, the suggested fix in a C file by clang-tidy is iRevValid > instead of rtRevValid. Ah there it was, thanks for the clarification! It was not highlighted in t

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau added a comment. In D144912#4203920 , @carlosgalvezp wrote: > Looks good but I fail to understand what exactly the patch fixes, can you > point me to an example in the tests? The patch fixes these enum tests in C language mode: enum REV_TYP

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

carlosgalvezp added a comment. Looks good but I fail to understand what exactly the patch fixes, can you point me to an example in the tests? It would be easier to review if the NFC changes had been done in a separate patch. Comment at: clang-tools-extra/test/clang-tidy/chec

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau added a comment. Hi, thanks PiotrZSL, the build is now passed and is green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144912/new/ https://reviews.llvm.org/D144912 ___ cfe-commits mailing lis

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau marked an inline comment as done. amurzeau added a comment. I see the build is still marked as failed in phabricator, but succeed in buildkite, do I need to do something, like a rebuild ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14491

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau updated this revision to Diff 501247. amurzeau added a comment. Fix clang-format error, release notes and factorize typedefs in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144912/new/ https://reviews.llvm.org/D144912 Files: cla

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:181-187 +- Changed hungarian prefixes for enums in C files to match C++ files (ie. + always use the enum type letters, for example `rt` prefix for enum tags of + `enum REV_TYPE`) in :doc:`readab

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau updated this revision to Diff 500905. amurzeau added a comment. Update the release notes too, to notify of this changes with C files. Suggest the user to use `EnumConstantPrefix` instead of `EnumConstantHungarianPrefix` to keep the previous behavior of using `i` for all enum tags. Repo

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau created this revision. amurzeau added reviewers: njames93, alexfh, kazu, dougpuob, aaron.ballman, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. amurzeau requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscri