[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. @int3 @thakis, et al - friendly 🔔 :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

int3 accepted this revision. int3 added a comment. This revision is now accepted and ready to land. lgtm Comment at: lld/MachO/UnwindInfoSection.cpp:346 -// If we have DWARF unwind info, create a CU entry that points to it. +// If we have DWARF unwind info, set the DW

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 523147. oontvoo marked an inline comment as done. oontvoo edited the summary of this revision. oontvoo added a comment. updated comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 523148. oontvoo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Dr

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 523354. oontvoo added a comment. rebase again (windows failures in flang tests looked unrelated) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 Files: clang/includ

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG09aaf53a05e3: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality… (authored by oontvoo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

thakis added a comment. This makes lld crash when linking a libc++ with object files built by a clang that also contains the patch. Here's a reduced (to just libc++), stand-alone repro that repros the crash in 6 seconds on my m1 mbp: https://bugs.chromium.org/p/chromium/issues/detail?id=1446967

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

thakis added a comment. Reverted in 4980eead4d0b4666d53dad07afb091375b3a13a0 for now. (The assert only happens when targeting x86_64, not arm64. The repro script above has the right `-arch` flag to toggle it.) Repository:

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo reopened this revision. oontvoo added a comment. This revision is now accepted and ready to land. In D144999#4356218 , @thakis wrote: > Reverted in 4980eead4d0b4666d53dad07afb091375b3a13a0 >

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 528965. oontvoo added a comment. rebase for rolling forward. (Will wait ~1 day before pushing to avoid possible stacking reverts because this depends on D151824 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 529283. oontvoo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Dr

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

fdeazeve added a comment. I believe this is breaking the LLDB tests: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/56106/changes https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/buildTimeTrend Build 56105 was passing, and the only relevant change seems to come from this rev

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. In D144999#4405793 , @fdeazeve wrote: > I believe this is breaking the LLDB tests: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/56106/changes > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/buildTimeTre

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. P.S: https://reviews.llvm.org/D152449 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

t.p.northover added a comment. I don't think this handles the no-personality case properly. For example this code leads to a DWARF entry now: void bar(int *) noexcept; void foo() { int arr; bar(&arr); } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

Michael137 added a comment. Looks like the latest reland of this patch broke some debug-info `cross-project-tests` on the Arm64 macOS buildbots: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-as/263/execution/node/54/log/ Failed Tests (2): cross-project-tests :: debuginfo-tests

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. In D144999#4407934 , @t.p.northover wrote: > I don't think this handles the no-personality case properly. For example this > code leads to a DWARF entry now: > > void bar(int *) noexcept; > void foo() { > int arr; >

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

Michael137 added a comment. In D144999#4408248 , @Michael137 wrote: > Looks like the latest reland of this patch > (`e60b30d5e3878e7d91f8872ec4c4dca00d4a2dfc`) broke some debug-info > `cross-project-tests` on the Arm64 macOS buildbots: > https://green

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. In D144999#4409149 , @Michael137 wrote: > In D144999#4408248 , @Michael137 > wrote: > >> Looks like the latest reland of this patch >> (`e60b30d5e3878e7d91f8872ec4c4dca00d4a2dfc`) broke

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. P.S This might have the same root-cause with the previous comment and could be fixed by D152540 as well. (not able to repro the failures yet - don't have arm64 readily available, will test it later this evening. but on linux x86-64 and

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

Michael137 added a comment. In D144999#4409671 , @oontvoo wrote: > P.S This might have the same root-cause with the previous comment and could > be fixed by D152540 as well. > (not able to repro the failures yet - don't

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

jasonmolenda added a comment. Michael and I looked into this. This simple c++ file is resulting in eh_frame unwind info on aarch64 darwin instead of compact unwind info. The eh_frame instructions don't describe the epilogue, so lldb is stopping on the final RET instruction after it has adjust

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. In D144999#4415137 , @jasonmolenda wrote: > Michael and I looked into this. This simple c++ file is resulting in > eh_frame unwind info on aarch64 darwin instead of compact unwind info. The > eh_frame instructions don't descr

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. In D144999#4415419 , @oontvoo wrote: > In D144999#4415137 , @jasonmolenda > wrote: > >> Michael and I looked into this. This simple c++ file is resulting in >> eh_frame unwind info on a

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

Michael137 added a comment. In D144999#4417731 , @oontvoo wrote: > In D144999#4415419 , @oontvoo wrote: > >> In D144999#4415137 , @jasonmolenda >> wrote: >> >>> Michael a