This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG938deaad8ac9: [clang][RISCV] Fix ABI lowering for _Float16
for FP ABIs (authored by asb).
Repository:
rG LLVM Github Mo
asb added inline comments.
Comment at: clang/test/CodeGen/RISCV/riscv64-abi.c:1909
- NOTE: These prefixes are unused and the list is autogenerated. Do not add
tests below this line:
-// LP64F: {{.*}}
kito-cheng wrote:
> This seems removed accidentally, I saw
asb updated this revision to Diff 505575.
asb added a comment.
Herald added a subscriber: jobnoorman.
Rebase.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145074/new/
https://reviews.llvm.org/D145074
Files:
clang/docs/ReleaseNotes.rst
clang/lib/CodeGen/TargetInfo.cpp
clang/test/
kito-cheng added a comment.
LGTM, just a nit :)
Comment at: clang/test/CodeGen/RISCV/riscv64-abi.c:1909
- NOTE: These prefixes are unused and the list is autogenerated. Do not add
tests below this line:
-// LP64F: {{.*}}
This seems removed accidentally, I
asb created this revision.
asb added reviewers: kito-cheng, jrtc27, reames, craig.topper.
Herald added subscribers: luke, wingo, pmatos, VincentWu, vkmr, frasercrmck,
evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl,
jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogf
