[PATCH] D145228: [clangd] Add clangd headers to install targets

ivanmurashko abandoned this revision. ivanmurashko added a comment. The diff is not required after https://reviews.llvm.org/D145302 deployed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145228/new/ https://reviews.llvm.org/D145228

[PATCH] D145228: [clangd] Add clangd headers to install targets

ivanmurashko added a comment. > If we consider the bare minimum with the only goal to build outside LLVM > source tree then we don’t need to copy all internal headers. At the case the > D145302 can be modified and we can end up > with the only one header

[PATCH] D145228: [clangd] Add clangd headers to install targets

ivanmurashko added a comment. In D145228#4174829 , @sammccall wrote: > I think this is a bit abstract though. Concretely, what API do you need here? > e.g. which headers do you want to include, to what end? If we consider the bare minimum with the only

[PATCH] D145228: [clangd] Add clangd headers to install targets

aaron.ballman added a comment. In D145228#4174829 , @sammccall wrote: > @aaron.ballman > > If someone wants to work on producing a more modular, component-based design, > that's probably a good idea (but tricky to get right). Probably a good place > to

[PATCH] D145228: [clangd] Add clangd headers to install targets

sammccall added a comment. @aaron.ballman If someone wants to work on producing a more modular, component-based design, that's probably a good idea (but tricky to get right). Probably a good place to start is working out what pieces can be moved into separate libraries with e.g. a coherent

[PATCH] D145228: [clangd] Add clangd headers to install targets

aaron.ballman added a comment. In D145228#4170864 , @sammccall wrote: > Clangd isn't designed as a collection of libraries. clangd is not my area of expertise, so I don't intend to step into the middle of this with my comment, but: one of the tenants

[PATCH] D145228: [clangd] Add clangd headers to install targets

ivanmurashko added a comment. In D145228#4174543 , @kadircet wrote: > I understand concerns about maintenance cost for the change. But I dare to ask why you think it is so high? Perhaps there are different expectations from the feature. I’m not

[PATCH] D145228: [clangd] Add clangd headers to install targets

kadircet requested changes to this revision. kadircet added a comment. This revision now requires changes to proceed. i agree with Sam's concerns here. clangd isn't designed to be consumed as a library, but rather as a binary through LSP. increasing surface are here and letting people build

[PATCH] D145228: [clangd] Add clangd headers to install targets

sammccall added a comment. In D145228#4170826 , @DmitryPolukhin wrote: > In D145228#4170792 , @sammccall > wrote: > >>> The install target for clang distributes the clangd static libs >> >> I don't think this

[PATCH] D145228: [clangd] Add clangd headers to install targets

DmitryPolukhin added a comment. In D145228#4170792 , @sammccall wrote: >> The install target for clang distributes the clangd static libs > > I don't think this was ever intended, looks like an accidental side-effect of > using LLVM's many cmake macros.

[PATCH] D145228: [clangd] Add clangd headers to install targets

sammccall added a comment. > The install target for clang distributes the clangd static libs I don't think this was ever intended, looks like an accidental side-effect of using LLVM's many cmake macros. Can we fix this instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145228: [clangd] Add clangd headers to install targets

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145228/new/ https://reviews.llvm.org/D145228

[PATCH] D145228: [clangd] Add clangd headers to install targets

ivanmurashko created this revision. ivanmurashko added reviewers: sammccall, alexfh, smeenai, aaron.ballman. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ivanmurashko requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.