sammccall added a comment.
Oops, sorry for the noise.
I'd forgotten that we're really interested in *why* we reach the conclusion,
not the conclusion itself - and that file/line are our proxy for "why" as
writing/maintaining descriptions is a burden.
Comment at:
klimek added a comment.
Answering the fundamental design question first.
Comment at: clang/lib/Format/ContinuationIndenter.cpp:289
Current.closesBlockOrBlockTypeList(Style)))
{
+DEBUG_FORMAT_TRACE_TOKEN(Current, "!canBreak");
sammccall added inline comments.
Comment at: clang/lib/Format/ContinuationIndenter.cpp:289
Current.closesBlockOrBlockTypeList(Style)))
{
+DEBUG_FORMAT_TRACE_TOKEN(Current, "!canBreak");
return false;
annotating all
klimek updated this revision to Diff 502123.
klimek added a comment.
Remove superfluous include.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145244/new/
https://reviews.llvm.org/D145244
Files:
clang/lib/Format/CMakeLists.txt
klimek created this revision.
klimek added a reviewer: sammccall.
Herald added a project: All.
klimek requested review of this revision.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D145244
Files:
clang/lib/Format/CMakeLists.txt