[PATCH] D145311: [clang-tidy] Make abseil-redundant-strcat-calls checker use header

2023-03-11 Thread Mike Crowe via Phabricator via cfe-commits
mikecrowe added a comment. In D145311#4184159 , @PiotrZSL wrote: > It's fine, absl::StrCat returns std::string. > So those changes are correct. Thanks. Would you like me to remove the unnecessary noise from the commit message then, or will you do that

[PATCH] D145311: [clang-tidy] Make abseil-redundant-strcat-calls checker use header

2023-03-10 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. It's fine, absl::StrCat returns std::string. So those changes are correct. Here you can find source code https://github.com/abseil/abseil-cpp/blob/master/absl/strings/str_cat.h

[PATCH] D145311: [clang-tidy] Make abseil-redundant-strcat-calls checker use header

2023-03-09 Thread Mike Crowe via Phabricator via cfe-commits
mikecrowe updated this revision to Diff 503884. mikecrowe added a comment. Herald added a subscriber: PiotrZSL. Re-upload using arc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145311/new/ https://reviews.llvm.org/D145311 Files: