[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

carlosgalvezp added a comment. In D145312#4187247 , @PiotrZSL wrote: > In D145312#4187195 , @carlosgalvezp > wrote: > >> @PiotrZSL I believe you have landed some patches of this chain. Would you >> mind sharing

[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9dc14cf1f7e: [clang-tidy] Make readability-string-compare check use string header (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

PiotrZSL added a comment. In D145312#4187195 , @carlosgalvezp wrote: > @PiotrZSL I believe you have landed some patches of this chain. Would you > mind sharing how you do it? I'm not an expert in Phabricator and simply doing > `arc patch D145312`

[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

carlosgalvezp added a comment. @mikecrowe I seems I cannot land this until it's rebased on top of `main`, would you be able to do that? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145312/new/ https://reviews.llvm.org/D145312 ___

[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

carlosgalvezp added a comment. @PiotrZSL I believe you have landed some patches of this chain. Would you mind sharing how you do it? I'm not an expert in Phabricator and simply doing `arc patch D145312` leads to cherry-pick conflicts, and when I solve them I don't end up having this patch as

[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145312/new/ https://reviews.llvm.org/D145312 ___ cfe-commits mailing list

[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

mikecrowe marked an inline comment as done. mikecrowe added inline comments. Herald added a subscriber: PiotrZSL. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/string-compare.cpp:4-8 -template -class allocator {}; -template -class char_traits {};

[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/string-compare.cpp:4-8 -template -class allocator {}; -template -class char_traits {}; -template , typename A = std::allocator> Would it make sense to add

[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

mikecrowe created this revision. mikecrowe added a reviewer: carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Improve the generic