This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6adb9a0602bc: [AMDGPU] Emit predefined macro
`__AMDGCN_CUMODE__` (authored by yaxunl).
Herald added a project: clang.
Repository:
rG LLVM Github
yaxunl updated this revision to Diff 521714.
yaxunl marked an inline comment as done.
yaxunl added a comment.
revised by Matt's comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145343/new/
https://reviews.llvm.org/D145343
Files:
arsenm added inline comments.
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:146
+return false;
+ return TargetFeature == "no-cumode";
+}
yaxunl wrote:
> arsenm wrote:
> > I don't understand the use of "no-cumode". Where is this defined?
> This
yaxunl added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:121-123
+def warn_drv_unsupported_option_for_processor : Warning<
+ "ignoring '%0' option as it is not currently supported for processor '%1'">,
+ InGroup;
arsenm
arsenm added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:121-123
+def warn_drv_unsupported_option_for_processor : Warning<
+ "ignoring '%0' option as it is not currently supported for processor '%1'">,
+ InGroup;
I'm
yaxunl updated this revision to Diff 521396.
yaxunl retitled this revision from "[AMDGPU] Emit predefined macro
`__AMDGCN_CUMODE`" to "[AMDGPU] Emit predefined macro `__AMDGCN_CUMODE__`".
yaxunl edited the summary of this revision.
yaxunl added a comment.
rename the macro to be consistent with
