[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

phosek added a comment. In D145449#4175864 , @phosek wrote: >> LLVM_ENABLE_PROJECTS is automatically forwarded from stage 1 builds to >> stage 2 builds, so setting FUCHSIA_ENABLE_LLDB has no effect on >> two-stage builds. > > That shouldn't be the case,

[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0e9c55db3b6: [Fuchsia] Add LLDB options to stage 1 cmake. (authored by mysterymath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145449/new/

[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

phosek added a comment. > LLVM_ENABLE_PROJECTS is automatically forwarded from stage 1 builds to > stage 2 builds, so setting FUCHSIA_ENABLE_LLDB has no effect on > two-stage builds. That shouldn't be the case, do you know where it's being passed through? Repository: rG LLVM Github Monorepo

[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

haowei accepted this revision. haowei added a comment. This revision is now accepted and ready to land. LGTM, but please wait @phosek to approve it. Comment at: clang/cmake/caches/Fuchsia.cmake:167 +if(FUCHSIA_ENABLE_LLDB) + list(APPEND _FUCHSIA_ENABLE_PROJECTS lldb) +endif()

[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

mysterymath added inline comments. Comment at: clang/cmake/caches/Fuchsia.cmake:167 +if(FUCHSIA_ENABLE_LLDB) + list(APPEND _FUCHSIA_ENABLE_PROJECTS lldb) +endif() haowei wrote: > You probably need a `string(REPLACE ";" "|" value >

[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

haowei added inline comments. Comment at: clang/cmake/caches/Fuchsia.cmake:167 +if(FUCHSIA_ENABLE_LLDB) + list(APPEND _FUCHSIA_ENABLE_PROJECTS lldb) +endif() You probably need a `string(REPLACE ";" "|" value "${_FUCHSIA_ENABLE_PROJECTS}")` after append a

[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

mysterymath created this revision. mysterymath added reviewers: phosek, haowei. Herald added a subscriber: abrachet. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LLVM_ENABLE_PROJECTS is