This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
lenary marked an inline comment as done.
Closed by commit rGcb7fb737858c: [AArch64] Assembly Support for
FEAT_GCS/FEAT_CHK (authored by lenary).
Changed prior to
lenary marked an inline comment as done.
lenary added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:1106
+
+def : TokenAlias<"DSYNC", "dsync">;
+
john.brawn wrote:
> It would make more sense to put this immediately after GCSB_DSYNC.
john.brawn accepted this revision.
john.brawn added a comment.
This revision is now accepted and ready to land.
LGTM, with one minor nitpick.
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:1106
+
+def : TokenAlias<"DSYNC", "dsync">;
+
It would make
lenary added a comment.
The CHKFEAT instruction here is not exactly as described in
https://developer.arm.com/downloads/-/exploration-tools today - but the next
release of that description will be updated with the new syntax.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
lenary created this revision.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: All.
lenary requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
This implements support for two new 2022 A-profile
