[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGe43247dd329c: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver (authored by domada). Changed prior to commit: https://reviews.llvm.org/D145579?vs=508977&id=509233#toc Repository: rG LLVM

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Thanks for implementing this, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 ___

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada marked an inline comment as done. domada added a comment. In D145579#4226542 , @tschuett wrote: > I wanted to ask whether you want to put an AMDGPU.cpp and AMD.cpp file in the > flang/lib/Frontend directory. @tschuett No, I don't plan to modify f

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada marked 2 inline comments as done. domada added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:149 +err.print(errorMsg.data(), llvm::errs()); +unsigned diagID = ci.getDiagnostics().getCustomDiagID( +clang::DiagnosticsEngine::Error, "Unsu

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada updated this revision to Diff 508977. domada added a comment. Patch rebased and added new test for checking incorrect wavefront sizes AMDGPU target features. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 Files: clang/lib/Basic/Targ

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

tschuett added a comment. I wanted to ask whether you want to put an AMDGPU.cpp and AMD.cpp file in the flang/lib/Frontend directory. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 ___ cfe-commits

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada added a comment. In D145579#4224157 , @tschuett wrote: > Do you want to move the AMDGPU changes into AMDGPU.cpp next to AMD.cpp? From > the conversation, there seems to be more target specific behaviours. @tschuett No. I don't plan to further ref

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

awarzynski added a comment. Thanks for the updates, mostly looks good. Just a couple of extra questions about the test coverage. Comment at: flang/lib/Frontend/FrontendActions.cpp:139-142 + // Clang does not append all target features to the clang -cc1 invocation. + // Some

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada updated this revision to Diff 508660. domada added a comment. Patch rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/Tool

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

yaxunl added a comment. In D145579#4224157 , @tschuett wrote: > Do you want to move the AMDGPU changes into AMDGPU.cpp next to AMD.cpp? From > the conversation, there seems to be more target specific behaviours. I prefer to defer further refactoring to

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

tschuett added a comment. Do you want to move the AMDGPU changes into AMDGPU.cpp next to AMD.cpp? From the conversation, there seems to be more target specific behaviours. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 __

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

yaxunl added a comment. LGTM about the AMDGPU TargetInfo change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:139-142 + // Clang does not append all target features to the clang -cc1 invocation. + // Some AMDGPU features are passed implicitly by the Clang frontend. + // That's why we need to extract impli

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada updated this revision to Diff 508618. domada retitled this revision from "[Flang][AMDGPU] Add support for AMDGPU to Flang driver" to "[Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver". domada edited the summary of this revision. domada added a comment. Rebase & applied review