[PATCH] D145579: [Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect

awarzynski added a comment. Really nice to see some shared code being elevated out of Clang into LLVM, thanks! I've only reviewed on the Flang driver changes. I will let the OpenMP experts to review the remaining bits. All in all looks good, I've only made some small suggestions. Thanks for w

[PATCH] D145579: [Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect

domada added a comment. D146612 presents the lowering from MLIR attributes to LLVM IR. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 ___ cfe-commits mailing list

[PATCH] D145579: [Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect

domada updated this revision to Diff 507269. domada retitled this revision from "[WIP][Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect" to "[Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect". domada added a comment. Patch rebased CHANGES SINCE LAST ACTION

[PATCH] D145579: [Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect

domada updated this revision to Diff 503672. domada added a comment. Fixed formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/T

[PATCH] D145579: [Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect

domada created this revision. domada added reviewers: jsjodin, agozillon, skatrak, TIFitis, kiranktp, dpalermo, kiranchandramohan, NimishMishra, awarzynski. domada added projects: Flang, OpenMP, MLIR, AMDGPU. Herald added subscribers: sunshaoce, Moerafaat, zero9178, bzcheeseman, kosarev, sdasgup3