[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

bjope added a comment. I have no objections about doing this revert. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145704/new/ https://reviews.llvm.org/D145704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam added a comment. In D145704#4184584 , @aaron.ballman wrote: > LGTM! If you don't hear otherwise from @kito-cheng, @bjope, @Wilco1 in the > next ~4 hours, feel free to land. Great! Thanks @aaron.ballman and @tstellar. CHANGES SINCE LAST

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! If you don't hear otherwise from @kito-cheng, @bjope, @Wilco1 in the next ~4 hours, feel free to land. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145704/new/

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

tstellar added a comment. We're holding -rc4 until this is merged, so it would be great if we could merge it on Friday. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145704/new/ https://reviews.llvm.org/D145704 ___ cfe-commits mailing list

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

aaron.ballman added a comment. In D145704#4182364 , @aaron.ballman wrote: > This variant comes with a .patch file added to the PR; that should be deleted > in the next round. Aside from that, the changes LGTM, but I'd like to give > precommit CI a

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

aaron.ballman added a comment. In D145704#4182341 , @zahiraam wrote: > In D145704#4182268 , @aaron.ballman > wrote: > >> Thank you for working on this! Because this is fixing an ABI break, if we >> can land

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam updated this revision to Diff 503865. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145704/new/ https://reviews.llvm.org/D145704 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Lex/Preprocessor.cpp clang/lib/Sema/SemaAttr.cpp

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam added a comment. In D145704#4182268 , @aaron.ballman wrote: > Thank you for working on this! Because this is fixing an ABI break, if we can > land this in time for the release candidate I think we should try to add this > to 16.0 to limit

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

aaron.ballman added a subscriber: tstellar. aaron.ballman added a comment. Thank you for working on this! Because this is fixing an ABI break, if we can land this in time for the release candidate I think we should try to add this to 16.0 to limit damage. CC @tstellar for his opinion. This

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam added subscribers: Wilco1, kito-cheng, bjope. zahiraam added a comment. Tagging @davemgreen, @kito-cheng, @bjope and @Wilco1 for awareness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145704/new/ https://reviews.llvm.org/D145704

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam created this revision. zahiraam added reviewers: andrew.w.kaylor, aaron.ballman. Herald added a subscriber: pengfei. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Setting __FLT_EVAL_METHOD__ to -1 with fast-math will set