[PATCH] D145721: [HIP] clang should pass `-mno-amdgpu-ieee` to -cc1

2023-04-02 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG806b74b0de6e: [HIP] clang should pass `-mno-amdgpu-ieee` to -cc1 (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github M

[PATCH] D145721: [HIP] clang should pass `-mno-amdgpu-ieee` to -cc1

2023-03-18 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 506296. yaxunl added a comment. fix tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145721/new/ https://reviews.llvm.org/D145721 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/hip-options.hip Index: clang/test/Driver/hip-op

[PATCH] D145721: [HIP] clang should pass `-mno-amdgpu-ieee` to -cc1

2023-03-17 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D145721#4182834 , @tra wrote: >> clang should pass `-mno-amdgpu-ieee` to -cc1 > > It would be useful to have some details on why we should pass that option. `-mamdgpu-ieee` was introduced by https://reviews.llvm.org/D77013 but

[PATCH] D145721: [HIP] clang should pass `-mno-amdgpu-ieee` to -cc1

2023-03-09 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. > clang should pass `-mno-amdgpu-ieee` to -cc1 It would be useful to have some details on why we should pass that option. Comment at: clang/test/Driver/hip-options.hip:133 +// IEEE-ON-NOT: clang{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}} "-mamdgpu-ieee" +

[PATCH] D145721: [HIP] clang should pass `-mno-amdgpu-ieee` to -cc1

2023-03-09 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kosarev, tpr, dstuttard, kzhuravl. Herald added a project: All. yaxunl requested review of this revision. Herald added subscribers: MaskRay, wdng. https://reviews.llvm.org/D145721 Files: clang/lib/Driver/ToolC