[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j added a comment. In D145770#4220246 , @mdtoguchi wrote: > @lamb-j - is it expected for any bundled objects created before your change > without the explicit env field to be able to be unbundled? Newly generated > bundles work as expected given

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

yaxunl added a comment. In D145770#4220246 , @mdtoguchi wrote: > @lamb-j - is it expected for any bundled objects created before your change > without the explicit env field to be able to be unbundled? Newly generated > bundles work as expected given

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

mdtoguchi added a comment. @lamb-j - is it expected for any bundled objects created before your change without the explicit env field to be able to be unbundled? Newly generated bundles work as expected given similar `-target` values, but older generated binaries fail to unbundle the target

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j added a comment. Herald added a subscriber: jplehr. Needed to update this after landing with two quick patch fixes: [clang-offload-bundler] Fix test failures and document typo (65fb636bd462) [clang-offload-bundler] Fix error with regex in bundler test (f3b991202689) There were

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

dyung added a comment. In D145770#4195018 , @dyung wrote: > @lamb-j the test clang-offload-bundler.c is failing on the PS4 linux builder, > can you take a look? > > https://lab.llvm.org/buildbot/#/builders/139/builds/37475 > > I don't know if it

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

dyung added a comment. @lamb-j the test clang-offload-bundler.c is failing on the PS4 linux builder, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/37475 I don't know if it matters, but this bot only builds the x86_64 target. Repository: rG LLVM Github Monorepo

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

This revision was automatically updated to reflect the committed changes. Closed by commit rGe48ae0dbd80d: [clang-offload-bundler] Standardize TargetID field for bundler (authored by lamb-j). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145770/new/

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j updated this revision to Diff 505227. lamb-j added a comment. Updating commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145770/new/ https://reviews.llvm.org/D145770 Files: clang/docs/ClangOffloadBundler.rst

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Please update the description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145770/new/ https://reviews.llvm.org/D145770

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j added a comment. In D145770#4190901 , @scott.linder wrote: > Is there a corresponding document update to go along with this? If consumers > of the bundles will begin to rely on this it should be documented that it is > guaranteed by the

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j updated this revision to Diff 504893. lamb-j added a comment. Adding note to documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145770/new/ https://reviews.llvm.org/D145770 Files: clang/docs/ClangOffloadBundler.rst

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

scott.linder added a comment. Is there a corresponding document update to go along with this? If consumers of the bundles will begin to rely on this it should be documented that it is guaranteed by the producer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j marked an inline comment as done. lamb-j added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:2 // REQUIRES: x86-registered-target -// REQUIRES: powerpc-registered-target // UNSUPPORTED: target={{.*}}-darwin{{.*}}, target={{.*}}-aix{{.*}}

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j updated this revision to Diff 504310. lamb-j added a comment. Herald added a reviewer: alexander-shaposhnikov. Adding another test, updating existing large test, and switching from ABI to env Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j added a comment. In D145770#4186142 , @yaxunl wrote: > In D145770#4185658 , @lamb-j wrote: > >> In D145770#4184996 , @yaxunl wrote: >> >>> The description needs

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

yaxunl added a comment. In D145770#4185658 , @lamb-j wrote: > In D145770#4184996 , @yaxunl wrote: > >> The description needs fix. "ABI field" should be "environment component". >> >> Also, we need a

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j added a comment. In D145770#4184996 , @yaxunl wrote: > The description needs fix. "ABI field" should be "environment component". > > Also, we need a clang-offload-bundler test which bundles with a non-canonical > triple and unbundles with a

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

yaxunl added a comment. The description needs fix. "ABI field" should be "environment component". Also, we need a clang-offload-bundler test which bundles with a non-canonical triple and unbundles with a canonical triple and vice versa. Comment at:

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j created this revision. Herald added a subscriber: kosarev. Herald added a project: All. lamb-j requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a reviewer: jdoerfert. Herald added a project: clang. The bundler accepts both of the