gbedwell added a subscriber: gbedwell.
gbedwell added a comment.
> > Also, I am really curious to know why CryptAcquireContext fails in those
> > cases!
>
>
> Me too. Once is a fluke, twice is a trend. Probably some obscure
> system-resource problem but it would be nice to be sure.
I'm
probinson closed this revision.
probinson marked an inline comment as done.
probinson added a comment.
r252800, thanks!
http://reviews.llvm.org/D14583
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
probinson marked an inline comment as done.
probinson added a comment.
In http://reviews.llvm.org/D14583#287406, @bcraig wrote:
> Looks good to me, but since this is in the LLVMSupport library, you should
> probably add llvm-commits to the subscriber list.
Ah, right, I should have. But I'm not
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a nit.
Also, I am really curious to know why CryptAcquireContext fails in those cases!
Comment at: lib/Support/Windows/Process.inc:421
@@ +420,3 @@
+/
bcraig added a subscriber: bcraig.
bcraig added a comment.
Looks good to me, but since this is in the LLVMSupport library, you should
probably add llvm-commits to the subscriber list.
http://reviews.llvm.org/D14583
___
cfe-commits mailing list
cfe-
probinson created this revision.
probinson added a reviewer: aaron.ballman.
probinson added a subscriber: cfe-commits.
We've had two reports in the past year that CryptAcquireContextW failed; but
without the Windows error code it's hard to know what's going on.
http://reviews.llvm.org/D14583
F