[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1fdcd5fbc09: [Flang] Allow compile *.f03, *.f08 file (authored by sunshaoce). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

sunshaoce updated this revision to Diff 504372. sunshaoce added a comment. Fix the issue of failing in the MSVC environment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 Files:

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

sunshaoce reopened this revision. sunshaoce added a comment. This revision is now accepted and ready to land. Sorry! My previous tests were not comprehensive enough, which resulted in failures in the MSVC environment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sunshaoce marked an inline comment as done. Closed by commit rG171794de533b: [Flang] Allow compile *.f03, *.f08 file (authored by sunshaoce). Repository: rG LLVM

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

sunshaoce updated this revision to Diff 504363. sunshaoce marked 2 inline comments as done. sunshaoce added a comment. Sorry, I just missed a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

awarzynski added inline comments. Comment at: flang/test/Driver/supported-suffices/f08-suffix.f08:4 +! CHECK: "{{.*}}flang-new" "-fc1" {{.*}} "/tmp/{{.*}}.o" +! CHECK: "{{.*}}ld" {{.*}} "/tmp/{{.*}}.o" +program f08 This line will not appear without

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

sunshaoce updated this revision to Diff 504362. sunshaoce added a comment. Address @awarzynski's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 Files: clang/lib/Driver/Types.cpp

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

sunshaoce updated this revision to Diff 504360. sunshaoce added a comment. Remove -flang-experimental-exec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 Files: clang/lib/Driver/Types.cpp

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

awarzynski added a comment. I'd move these tests to flang/test/Driver/supported-suffices. That would help documenting what these tests actual check for. Also, one could be tempted to test for other suffices and then it would be nice to keep them in one place. Ta! Comment at:

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

awarzynski added a comment. In D145845#4186608 , @clementval wrote: > In D145845#4186607 , @awarzynski > wrote: > >> Thanks! >> >> In D145845#4186590 , @clementval >>

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

sunshaoce added a comment. Before $ /home/sunshaoce/dev/llvm-project/build/bin/flang-new /home/sunshaoce/dev/llvm-project/build/temp.f03 -flang-experimental-exec -o temp.out -### flang-new version 17.0.0 (https://github.com/llvm/llvm-project.git 890e6c871d31dca9e461c01118cf25fb303b9cad)

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

sunshaoce updated this revision to Diff 504359. sunshaoce added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 Files: clang/lib/Driver/Types.cpp flang/test/Driver/f03-suffix.f03

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

clementval added a comment. In D145845#4186607 , @awarzynski wrote: > Thanks! > > In D145845#4186590 , @clementval > wrote: > >> Thanks. Can you add tests in `flang/test/Driver`? > > Hm, this is a `clangDriver`

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

awarzynski added a comment. Thanks! In D145845#4186590 , @clementval wrote: > Thanks. Can you add tests in `flang/test/Driver`? Hm, this is a `clangDriver` change rather than anything Flang specific 樂 . Btw, how does

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

clementval added a comment. Thanks. Can you add tests in `flang/test/Driver`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 ___ cfe-commits mailing list

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

sunshaoce created this revision. sunshaoce added reviewers: awarzynski, klausler, clementval, sscalpone. Herald added a project: All. sunshaoce requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Fix issue #61260 Repository: rG