[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5bebb3fb402: [Driver] Allow XRay on Apple Silicon (authored by ilammy, committed by MaskRay). Changed prior to commit: https://reviews.llvm.org/D145849?vs=530285&id=533116#toc Repository: rG LLVM Gi

[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

MaskRay added a comment. In D145849#4436623 , @MaskRay wrote: > In D145849#4430870 , @ilammy wrote: > >> In D145849#4412286 , @MaskRay >> wrote: >> >>> However, `Triple.i

[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

MaskRay added a comment. In D145849#4430870 , @ilammy wrote: > In D145849#4412286 , @MaskRay wrote: > >> However, `Triple.isMacOSX()` is allowed before the feature actually works >> and `compiler-rt/test/xray/lit

[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

ilammy added a comment. In D145849#4412286 , @MaskRay wrote: > However, `Triple.isMacOSX()` is allowed before the feature actually works and > `compiler-rt/test/xray/lit.cfg.py` tests it. I have some patches for `compiler-rt` cooking, fixing the build f

[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

MaskRay added a comment. This is a kinda odd case. Normally we should enable the option in the driver when the feature actually works. However, `Triple.isMacOSX()` is allowed before the feature actually works and `compiler-rt/test/xray/lit.cfg.py` tests it. `clang/test/Driver/XRay/` is broken a

[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

ilammy updated this revision to Diff 530285. ilammy added a comment. Addressing feedback by @MaskRay: - Moved `// REQUIRES:` directive to the top of the test file - Replaced legacy `-target` option with proper `--target` in tests - Also rebased on updated trunk CHANGES SINCE LAST ACTION http

[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/XRay/xray-instrument-macos.c:1 +// RUN: %clang -o /dev/null -v -fxray-instrument -target aarch64-apple-darwin20 -c %s // RUN: %clang -o

[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

ilammy created this revision. ilammy added reviewers: MaskRay, ianlevesque, dberris. ilammy added a project: clang. Herald added a subscriber: kristof.beyls. Herald added a project: All. ilammy requested review of this revision. Herald added a subscriber: cfe-commits. Codegen can handle XRay for A