[PATCH] D145857: [X86] Make triple ArchName override OS for i686 and i786

2023-03-12 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 504498. pengfei added a comment. Support i886 and i986. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145857/new/ https://reviews.llvm.org/D145857 Files: clang/lib/Driver/ToolChains/Arch/X86.cpp clang/test

[PATCH] D145857: [X86] Make triple ArchName override OS for i686 and i786

2023-03-12 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 504497. pengfei added a comment. Only make OS override i386. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145857/new/ https://reviews.llvm.org/D145857 Files: clang/lib/Driver/ToolChains/Arch/X86.cpp clang

[PATCH] D145857: [X86] Make triple ArchName override OS for i686 and i786

2023-03-11 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 504401. pengfei added a comment. Fix lit failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145857/new/ https://reviews.llvm.org/D145857 Files: clang/lib/Driver/ToolChains/Arch/X86.cpp clang/test/Drive

[PATCH] D145857: [X86] Make triple ArchName override OS for i686 and i786

2023-03-11 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 504400. pengfei added a comment. Fix typo & add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145857/new/ https://reviews.llvm.org/D145857 Files: clang/lib/Driver/ToolChains/Arch/X86.cpp clang/test/

[PATCH] D145857: [X86] Make triple ArchName override OS for i686 and i786

2023-03-11 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei planned changes to this revision. pengfei added a comment. In D145857#4186957 , @craig.topper wrote: > Did you test this? I kind of expected the triple would be normalized before > this. I’m not at a computer to check. No, I just tried with gdb

[PATCH] D145857: [X86] Make triple ArchName override OS for i686 and i786

2023-03-11 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. Did you test this? I kind of expected the triple would be normalized before this. I’m not at a computer to check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145857/new/ https://reviews.llvm.org/D145857 ___

[PATCH] D145857: [X86] Make triple ArchName override OS for i686 and i786

2023-03-11 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei created this revision. Herald added a project: All. pengfei requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Fixes #61347 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145857 Files: clang/lib/Driver/To