This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe26dad0a661e: [clangd] Add missing unittests to build graph
(authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
doh, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145921/new/
https://reviews.llvm.org/D145921
kadircet marked an inline comment as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/unittests/tweaks/SpecialMembersTests.cpp:21
EXPECT_UNAVAILABLE("struct S { ^ };");
- EXPECT_UNAVAILABLE("union ^U {};");
+ EXPECT_AVAILABLE("union ^U {};");
kadircet updated this revision to Diff 504597.
kadircet marked an inline comment as done.
kadircet added a comment.
- Disable special members tweaks on unions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145921/new/
hokein added inline comments.
Comment at: clang-tools-extra/clangd/unittests/tweaks/SpecialMembersTests.cpp:21
EXPECT_UNAVAILABLE("struct S { ^ };");
- EXPECT_UNAVAILABLE("union ^U {};");
+ EXPECT_AVAILABLE("union ^U {};");
EXPECT_AVAILABLE("struct ^S { S(const S&);
kadircet created this revision.
kadircet added reviewers: sammccall, hokein.
Herald added a subscriber: arphaman.
Herald added a project: All.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Also
