[PATCH] D146023: [AMDGPU] Remove Code Object V2

2023-09-08 Thread Pierre van Houtryve via Phabricator via cfe-commits
Pierre-vh abandoned this revision. Pierre-vh added a comment. https://github.com/llvm/llvm-project/pull/65715 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146023/new/ https://reviews.llvm.org/D146023

[PATCH] D146023: [AMDGPU] Remove Code Object V2

2023-08-23 Thread Pierre van Houtryve via Phabricator via cfe-commits
Pierre-vh added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146023/new/ https://reviews.llvm.org/D146023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146023: [AMDGPU] Remove Code Object V2

2023-08-04 Thread Pierre van Houtryve via Phabricator via cfe-commits
Pierre-vh added inline comments. Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:5598 return ParseDirectiveHSAMetadata(); } else { -if (IDVal == ".hsa_code_object_version") cfang wrote: > Are you sure Non-HSA does not have the four

[PATCH] D146023: [AMDGPU] Remove Code Object V2

2023-08-03 Thread Changpeng Fang via Phabricator via cfe-commits
cfang added a comment. Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:5598 return ParseDirectiveHSAMetadata(); } else { -if (IDVal == ".hsa_code_object_version") Are you sure Non-HSA does not have the four directives you

[PATCH] D146023: [AMDGPU] Remove Code Object V2

2023-08-01 Thread Pierre van Houtryve via Phabricator via cfe-commits
Pierre-vh added inline comments. Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:5583 + // FIXME: Shouldn't be needed anymore? Should we remove this directive + // entirely? See `amdpal-elf.ll` - the output ASM contains both amdgcn_target

[PATCH] D146023: [AMDGPU] Remove Code Object V2

2023-06-06 Thread Scott Linder via Phabricator via cfe-commits
scott.linder added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:520 - assert(Func.getCallingConv() == CallingConv::AMDGPU_KERNEL || - Func.getCallingConv() == CallingConv::SPIR_KERNEL); + if (Func.getCallingConv() !=

[PATCH] D146023: [AMDGPU] Remove Code Object V2

2023-06-06 Thread Pierre van Houtryve via Phabricator via cfe-commits
Pierre-vh added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:520 - assert(Func.getCallingConv() == CallingConv::AMDGPU_KERNEL || - Func.getCallingConv() == CallingConv::SPIR_KERNEL); + if (Func.getCallingConv() !=

[PATCH] D146023: [AMDGPU] Remove Code Object V2

2023-06-01 Thread Scott Linder via Phabricator via cfe-commits
scott.linder added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:520 - assert(Func.getCallingConv() == CallingConv::AMDGPU_KERNEL || - Func.getCallingConv() == CallingConv::SPIR_KERNEL); + if (Func.getCallingConv() !=

[PATCH] D146023: [AMDGPU] Remove Code Object V2

2023-06-01 Thread Pierre van Houtryve via Phabricator via cfe-commits
Pierre-vh added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146023/new/ https://reviews.llvm.org/D146023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146023: [AMDGPU] Remove Code Object V2

2023-05-11 Thread Pierre van Houtryve via Phabricator via cfe-commits
Pierre-vh removed a reviewer: jdoerfert. Pierre-vh added a comment. Herald added a reviewer: jdoerfert. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146023/new/ https://reviews.llvm.org/D146023

[PATCH] D146023: [AMDGPU] Remove Code Object V2

2023-03-15 Thread Pierre van Houtryve via Phabricator via cfe-commits
Pierre-vh added inline comments. Comment at: llvm/test/MC/AMDGPU/hsa-gfx10.s:3 -// RUN: llvm-mc -filetype=obj -triple amdgcn--amdhsa -mcpu=gfx1010 --amdhsa-code-object-version=2 -mattr=-wavefrontsize32,+wavefrontsize64 -show-encoding %s | llvm-readobj -S --sd --syms - |

[PATCH] D146023: [AMDGPU] Remove Code Object V2

2023-03-14 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. Is clover still relying on the cov2 support? Comment at: clang/include/clang/Basic/TargetOptions.h:85 COV_None, -COV_2 = 200, COV_3 = 300, I wouldn't remove the enum field, just add a comment that emission is unsupported

[PATCH] D146023: [AMDGPU] Remove Code Object V2

2023-03-14 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. LGTM on clang side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146023/new/ https://reviews.llvm.org/D146023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146023: [AMDGPU] Remove Code Object V2

2023-03-14 Thread Konstantin Zhuravlyov via Phabricator via cfe-commits
kzhuravl added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:1379 .. warning:: - Code object V2 is not the default code object version emitted by - this version of LLVM. + Code object V2 emission is no longer supported by this version of LLVM.