This revision was automatically updated to reflect the committed changes.
Closed by commit rG82c8bf8fcc91: [clangd] Patch main file macros in preamble
(authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146028/new/
kadircet updated this revision to Diff 505093.
kadircet marked an inline comment as done.
kadircet added a comment.
- Rebase
- Prevent unnecessary copies
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146028/new/
https://reviews.llvm.org/D146028
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/Preamble.cpp:942
MainFileMacros PreamblePatch::mainFileMacros() const {
if (PatchContents.empty())
nit: maybe
kadircet created this revision.
Herald added a subscriber: arphaman.
Herald added a project: All.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Depends on D146026
