[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9fc3b4acbc92: [clang] Add a namespace for interesting identifiers. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/

[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

zahiraam updated this revision to Diff 533583. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/include/clang/Basic/IdentifierTable.h clang/include/clang/Basic/TokenKinds.def clang/include/clang/Basic/TokenKinds.h

[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 ___ cfe-commits mailing list

[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

zahiraam updated this revision to Diff 533360. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/include/clang/Basic/IdentifierTable.h clang/include/clang/Basic/TokenKinds.def

[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

rjmccall added a comment. Yes, this is very close, thank you. Comment at: clang/include/clang/Basic/TokenKinds.def:805 +INTERESTING_IDENTIFIER(float_t) +INTERESTING_IDENTIFIER(double_t) +INTERESTING_IDENTIFIER(FILE) I think it would be cleaner if you added

[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6784 + if (II->getInterestingIdentifierID() != 0) +NewTD->addAttr(AvailableOnlyInDefaultEvalMethodAttr::Create(Context)); }