klimek added a comment.
Submitted.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146310/new/
https://reviews.llvm.org/D146310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9e9e096ae95b: [clang-format] Fix dropped else.
(authored by klimek).
Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay.
jaredgrubb added a comment.
Manuel, if you're happy with the change, do you mind committing it? I don't
have commit access (at least I've never requested it, so I assume I can't, I've
never tried)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
jaredgrubb added a comment.
Yeh, I considered trying to craft one as courtesy but this seemed like a very
far edge case and didn't seem really worth it. So glad you agree :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146310/new/
klimek added a comment.
Thanks, yes, I did not intend to delete the else. This only triggers with
fuzzing with rather involved inputs, thus I wasn't able to create a nice enough
unit test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146310/new/
jaredgrubb added a comment.
The difference doesn't appear to affect any unit tests (which is unfortunate),
but I think you didn't mean to remove this else, based both on the logic of the
original commit and the format of the patched line.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
jaredgrubb created this revision.
jaredgrubb added a reviewer: klimek.
jaredgrubb added a project: clang-format.
Herald added a project: All.
jaredgrubb requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
A patch (398cddf6acec
