This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGafce10c5b60f: [clang][ExtractAPI] Add semicolons for enum,
typedef, struct declaration… (authored by chaitanyav, committed by dang).
Repository:
r
chaitanyav added a comment.
Name: NagaChaitanya Vellanki
email: pnag...@protonmail.com
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146354/new/
https://reviews.llvm.org/D146354
___
cfe-commits mailing l
chaitanyav added a comment.
Thank you, Please go ahead and Commit the change. I don't have commit access,
Will follow the instructions on the page to get access.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146354/new/
https://reviews.llvm.org/D1
dang accepted this revision.
dang added a comment.
This revision is now accepted and ready to land.
LGTM! I think it's fine to go ahead and land this (premerge check are not a
requirement). Have you contributed to LLVM before? If not I will need to commit
it on your behalf. Once that is done you
chaitanyav added a comment.
The debian build is failing because of this
https://github.com/google/llvm-premerge-checks/issues/436
The windows build is failing because of
https://github.com/llvm/llvm-project/issues/61519, i see that the fix
(https://reviews.llvm.org/rGd233c7b814071e8b9345b1c254
chaitanyav updated this revision to Diff 506309.
chaitanyav added a comment.
- Update reference output in underscored.c
- combine return and append semicolon fragment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146354/new/
https://reviews.llvm.or
chaitanyav updated this revision to Diff 506308.
chaitanyav added a comment.
- Update reference output in underscored.c
- combine return and append semicolon fragment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146354/new/
https://reviews.llvm.or
chaitanyav created this revision.
chaitanyav added a reviewer: dang.
Herald added a reviewer: ributzka.
Herald added a project: All.
chaitanyav requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixes https://github.com/llvm/llvm-project/issue
