This revision was automatically updated to reflect the committed changes.
Closed by commit rL254682: LLDB JIT needs android vector passing rules.
(authored by srhines).
Changed prior to commit:
http://reviews.llvm.org/D14639?vs=41654=41837#toc
Repository:
rL LLVM
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
Ouch, that 2012 vector passing ABI break is a bummer. :(
Comment at: lib/CodeGen/TargetInfo.cpp:5236
@@ +5235,3 @@
+ if (const VectorType *VT =
srhines updated this revision to Diff 41654.
srhines added a comment.
Switched to isPowerOf2_32() and added more details about Android's ABI.
http://reviews.llvm.org/D14639
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGen/arm-abi-vector.c
Index: test/CodeGen/arm-abi-vector.c
srhines marked 3 inline comments as done.
srhines added a comment.
I uploaded a fixed version to use isPowerOf2_32() and more comments. Thanks for
the reviews.
http://reviews.llvm.org/D14639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rnk added a comment.
lgtm
http://reviews.llvm.org/D14639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
srhines commandeered this revision.
srhines added a reviewer: ADodds.
srhines added a comment.
Commandeering, since I am going to upload a version with the updated tests.
Repository:
rL LLVM
http://reviews.llvm.org/D14639
___
cfe-commits mailing
rnk added a subscriber: rnk.
rnk added a comment.
Were these changes made to AOSP Clang to match upstream GCC, or some custom
Android version of GCC? Where would one go to find ground truth on how these
types should be passed?
http://reviews.llvm.org/D14639
srhines added a comment.
In http://reviews.llvm.org/D14639#300077, @rnk wrote:
> Were these changes made to AOSP Clang to match upstream GCC, or some custom
> Android version of GCC? Where would one go to find ground truth on how these
> types should be passed?
These changes are reverting to
ADodds created this revision.
ADodds added reviewers: asl, rsmith.
ADodds added subscribers: pirama, cfe-commits.
ADodds set the repository for this revision to rL LLVM.
Herald added subscribers: srhines, danalbert, tberghammer, aemerson.
Looking into some recent issues with LLDBs expression
